feat: add repo mode #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mafredri
force-pushed
the
mafredri/repo-mode
branch
4 times, most recently
from
6d6fc75 to
58c0b94
Compare
mafredri
force-pushed
the
mafredri/repo-mode
branch
from
58c0b94 to
0c1eaf6
Compare
johnstcn
reviewed
Aug 5, 2024
mafredri
force-pushed
the
mafredri/repo-mode
branch
from
ebd672f to
a7ad981
Compare
johnstcn
approved these changes
Aug 5, 2024
| ln, err := (&net.ListenConfig{}).Listen(ctx, "tcp", "localhost:0") | ||
| require.NoError(t, err, "listen") | ||
|
|
||
| go func() { |
There was a problem hiding this comment.
do we need to wait for this goroutine to exit?
There was a problem hiding this comment.
Not worth the extra complexity here I think, we're not using leak detection (yet).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.